Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ConfigForm): Update uniforms-patternfly #1556

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Oct 10, 2024

Context

This version reverts the change about inserting the array elements at the beginning of the array (#1102) but brings other fixes:

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a887b87). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage        ?   80.00%           
  Complexity      ?      272           
=======================================
  Files           ?      276           
  Lines           ?     7838           
  Branches        ?     1495           
=======================================
  Hits            ?     6271           
  Misses          ?     1506           
  Partials        ?       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip requested a review from tplevko October 10, 2024 14:30
@tplevko
Copy link
Contributor

tplevko commented Oct 10, 2024

Seems like the change introduced a bug causing a warning This node cannot be configured yet. Need to investigate.

@lordrip lordrip force-pushed the chore/update-uniforms-patternfly branch from c0f8808 to 87446cc Compare October 14, 2024 14:10
@lordrip lordrip changed the title chore(ConfigForm): Update uniforms-patternfly for adding array elements at the top chore(ConfigForm): Update uniforms-patternfly Oct 14, 2024
@lordrip lordrip marked this pull request as draft October 14, 2024 14:18
This version reverts the change about inserting the array elements at
the beginning of the array
(KaotoIO#1102) but brings another fixes:

fix: KaotoIO#1438
fix: KaotoIO#1439
@lordrip lordrip force-pushed the chore/update-uniforms-patternfly branch from 87446cc to 9ac14ef Compare October 14, 2024 15:34
Copy link

sonarcloud bot commented Oct 14, 2024

@lordrip lordrip marked this pull request as ready for review October 14, 2024 16:02
@lordrip lordrip merged commit 8277e99 into KaotoIO:main Oct 14, 2024
13 checks passed
@lordrip lordrip deleted the chore/update-uniforms-patternfly branch October 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants